Hi Mark,
On Wed, Jul 03, 2013 at 05:06:37PM +0100, Mark Brown wrote:
On Thu, Jun 20, 2013 at 03:20:23PM +0200, Markus Pargmann wrote:
- ssi_private->use_dma = !of_property_read_bool(np, "fsl,imx-fiq");
This binding should be documented. I'm not sure it really needs to be a binding, though - is it not possible for the driver to just figure out that DMA won't work automatically (for example by looking at the CODEC in use)? I'm not sure this is a good name either, it should be saying why the FIQ is needed rather than saying that we should use the FIQ.
I think fsl_ssi_startup is the first function in which we know which codec is connected to fsl-ssi. There we have access to the pcm runtime, which stores the codec used. But that is too late for the ssi setup.
I could use of_find_compatible_node to search for the wm9712 codec, but that would assume that there is only one codec attached to the system.
Perhaps "fsl,fiq-filter-codec-stream" is a better name for the binding?
Regards,
Markus