On Wed, Jul 08, 2020 at 10:44:19AM +0100, Srinivas Kandagatla wrote:
On 07/07/2020 17:52, Pierre-Louis Bossart wrote:
if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) - q6asm_write_async(prtd->audio_client, - prtd->pcm_count, 0, 0, NO_TIMESTAMP); + q6asm_write_async(prtd->audio_client, prtd->stream_id, + prtd->pcm_count, 0, 0, 0);
sound/soc/qcom/qdsp6/q6asm.h:#define NO_TIMESTAMP 0xFF00
is the change on the previous line intentional?
May be not!
Plan is that the users of these apis will send flags directly instead of boiler plating this!
This change should go as part of next patch("[PATCH 04/11] ASoC: q6asm: use flags directly from asm-dai") which would make it much clear!
It should be in here.
Please be also consistent in your use of ASM, especially given that asm is a widely used name in the kernel.