7 Oct
2014
7 Oct
'14
8:58 p.m.
At Tue, 7 Oct 2014 19:54:43 +0100, Mark Brown wrote:
On Tue, Oct 07, 2014 at 08:14:00PM +0200, Takashi Iwai wrote:
Mark Brown wrote:
I don't actually see it as a readability concern - to me having the get and release close to each other and especially having them at the same level of indentation helps.
I do understand the merit, but it looks uglier to my taste. The success path goes again with if (ret). (Or we'd need two goto's or deeper if-else blocks.)
That looks ugly, yes - I'd be doing a check for ret before the second property call or something. Or just put the pdata check in the existing error path.
Well, I don't mind much how it'll be fixed, so I rather toss this fix to you. Feel free to cook :)
Takashi