On 8/19/2020 9:31 PM, Colin King wrote:
From: Colin Ian King colin.king@canonical.com
Currently drvdata->clks is not being checked for an allocation failure, leading to potential null pointer dereferencing. Fix this by adding a check and returning -ENOMEM if an error occurred.
Addresses-Coverity: ("Dereference null return value") Fixes: 1220f6a76e77 ("ASoC: qcom: Add common array to initialize soc based core clocks") Signed-off-by: Colin Ian King colin.king@canonical.com
Thanks for the fix.
Reviewed-by: Rohit kumar rohitkr@codeaurora.org
sound/soc/qcom/lpass-apq8016.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/qcom/lpass-apq8016.c b/sound/soc/qcom/lpass-apq8016.c index dd9e3dd014f6..5c8ae225cd5d 100644 --- a/sound/soc/qcom/lpass-apq8016.c +++ b/sound/soc/qcom/lpass-apq8016.c @@ -168,6 +168,8 @@ static int apq8016_lpass_init(struct platform_device *pdev)
drvdata->clks = devm_kcalloc(dev, variant->num_clks, sizeof(*drvdata->clks), GFP_KERNEL);
if (!drvdata->clks)
return -ENOMEM;drvdata->num_clks = variant->num_clks;
for (i = 0; i < drvdata->num_clks; i++)