Re: [alsa-devel] [PATCH v4] ASoC: Add Freescale SGTL5000 codec support

On Sun, Feb 20, 2011 at 6:09 PM, zhaoming.zeng@freescale.com wrote:

+#Freescale SGTL5000 codec +config SND_SOC_SGTL5000

• tristate

I meant that you should add actual "help" text so that a person selecting this driver would know what it is. Like this:

config SND_SOC_SGTL5000 tristate "Freescale SGTL5000 audio codec" help Select this option to enable the Freescale SGTL5000 audio codec, etc etc

Add some text that explains the capabilities and limitations of this driver (e.g. what features of the codec are *not* supported)

Other than that, the driver looks okay to me, although I am surprised your toolchain insists on the void* cast.