Re: [PATCH] ALSA: hda: intel-sdw-acpi: fix usage of device_get_named_child_node()

Hi Takashi,

...

The documentation for device_get_named_child_node() mentions this important point:

" The caller is responsible for calling fwnode_handle_put() on the returned fwnode pointer. "

Add fwnode_handle_put() to avoid a leaked reference.

Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com

Can we have a corresponding Fixes tag?

Good question.

The initial code was in

6d2c66695bf3 ("soundwire: intel: transition to 3 steps initialization")

but then moved with

08c2a4bc9f2a ("ALSA: hda: move Intel SoundWire ACPI scan to dedicated module")

I guess a Fixes tag for the latter is good enough, it's a 2021 commit and that would probably cover most SoundWire platforms.