Iwai-san,
On Nov 27 2014 21:45, Takashi Sakamoto wrote:
On Nov 26 2014 23:38, Clemens Ladisch wrote:
Takashi Sakamoto wrote:
On Nov 26 2014 06:52, Clemens Ladisch wrote:
There are several devices that expect to receive MIDI data only in the first eight data blocks of a packet. If the driver restricts the data rate to the allowed rate (as mandated by the specification, but not yet implemented by this driver), this happens naturally. Therefore, there is no reason to ever try to use more data packets with any device.
Signed-off-by: Clemens Ladisch clemens@ladisch.de
sound/firewire/amdtp.c | 10 +++++++--- sound/firewire/amdtp.h | 3 --- sound/firewire/bebob/bebob_stream.c | 7 ------- sound/firewire/fireworks/fireworks_stream.c | 5 ----- 4 files changed, 7 insertions(+), 18 deletions(-)
Reviewed-by: Takashi Sakamoto o-takashi@sakamocchi.jp Tested-by: Takashi Sakamoto o-takashi@sakamocchi.jp
I tested these two patch with below devices. All of them can transmit MIDI messages correctly at any sampling transfer tates.
M-Audio: FIreWire 1814 (snd-bebob) M-Audio: FireWire 410 (snd-bebob) M-Audio: FireWire AudioPhile (snd-bebob) M-Audio: Ozonic (snd-bebob) Yamaha: GO44 (snd-bebob) Yamaha: GO46 (snd-bebob) Echo Audio: AudioFire4 (snd-fireworks) Echo Audio: AudioFirePre8 (snd-fireworks) TC Electronic: Impact Twin (snd-dice)
These two patches solves one of issues which I wrote in my report. 9.5 A lack of throttles for MIDI messages in outgoing stream https://github.com/takaswie/alsa-firewire-report
I think these two patches are deserved to merge. Could you apply these two patches to linux-next?
Regards
Takashi Sakamoto o-takashi@sakamocchi.jp