Re: [PATCH v3] ALSA: pcm: auto-fill buffer with silence when draining playback

On 10. 05. 23 18:29, Oswald Buddenhagen wrote:

Draining will always playback somewhat beyond the end of the filled buffer. This would produce artifacts if the user did not set up the auto-silencing machinery, which is an extremely easy mistake to make, as the API strongly suggests convenient fire-and-forget semantics. This patch makes it work out of the box.

Signed-off-by: Oswald Buddenhagen oswald.buddenhagen@gmx.de

NAK. Already implemented in alsa-lib which is enough for the first implementation. This patch also does not set the perfect drain flag nor handles the silence suppression for the user space (double fill) [1].

Jaroslav

[1] https://lore.kernel.org/alsa-devel/20230502115536.986900-1-perex@perex.cz/