On Mon, May 26, 2014 at 05:38:55PM +0530, Vinod Koul wrote:
From: Subhransu S. Prusty subhransu.s.prusty@intel.com
For DSPs we need to set and get the value for snd_kcontrol. This is currently done by dapm_kcontrol_set/get_value, so create a wrapper snd_soc_dapm_kcontrol_get/set_value APIs to let drivers use this
Can you provide any more detail on this than just simply stating that this is needed for DSPs - why do DSPs need it, what are they going to do with it?
} +unsigned int snd_soc_dapm_kcontrol_get_value(
Missing blank line.
- const struct snd_kcontrol *kcontrol)
+{
- dapm_kcontrol_get_value(kcontrol);
+} +EXPORT_SYMBOL_GPL(snd_soc_dapm_kcontrol_get_value);
This function has a return value but no return statement, I'm surprised the compiler didn't tell you this. To be honest I'm not sure why dapm_kcontrol_get_value() wasn't just exported, the wrapper isn't adding much and the function name is already so long that snd_soc_ isn't going to hurt.