On Sun, Jun 02, 2024 at 06:57:12PM +0300, Andy Shevchenko wrote:
Make two APIs look similar. Hence convert match_string() to be a 2-argument macro. In order to avoid unneeded churn, convert all users as well. There is no functional change intended.
Looks nice, thanks for doing this.
diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index ac6293c24976..2d317c7e1cea 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -210,7 +210,7 @@ void pcie_ecrc_get_policy(char *str) { int i;
- i = match_string(ecrc_policy_str, ARRAY_SIZE(ecrc_policy_str), str);
- i = match_string(ecrc_policy_str, str); if (i < 0) return;
Acked-by: Bjorn Helgaas bhelgaas@google.com # drivers/pci/
+++ b/mm/vmpressure.c @@ -388,7 +388,7 @@ int vmpressure_register_event(struct mem_cgroup *memcg,
/* Find required level */ token = strsep(&spec, ",");
- ret = match_string(vmpressure_str_levels, VMPRESSURE_NUM_LEVELS, token);
- ret = match_string(vmpressure_str_levels, token);
VMPRESSURE_NUM_LEVELS looks like it's no longer used?
if (ret < 0) goto out; level = ret; @@ -396,7 +396,7 @@ int vmpressure_register_event(struct mem_cgroup *memcg, /* Find optional mode */ token = strsep(&spec, ","); if (token) {
ret = match_string(vmpressure_str_modes, VMPRESSURE_NUM_MODES, token);
ret = match_string(vmpressure_str_modes, token);
Ditto.
if (ret < 0) goto out; mode = ret;