At Fri, 31 Jul 2009 08:32:03 +0200 (CEST), Julia Lawall wrote:
From: Julia Lawall julia@diku.dk
Check that the result of kzalloc is not NULL before a dereference.
The semantic match that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/)
// <smpl> @@ expression *x; identifier f; constant char *C; @@
x = (kmalloc|kcalloc|kzalloc)(...); ... when != x == NULL when != x != NULL when != (x || ...) ( kfree(x) | f(...,C,...,x,...) | *f(...,x,...) | *x->f ) // </smpl>
Signed-off-by: Julia Lawall julia@diku.dk
Applied now. But, please fix the path of the file correctly applicable to linux kernel tree at the next time. It includes /var/x/y, and confuses git am totally.
thanks,
Takashi
sound/aoa/core/gpio-pmf.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/var/linuxes/linux-next/sound/aoa/core/gpio-pmf.c b/var/julia/linuxcopy/sound/aoa/core/gpio-pmf.c index 5ca2220..1dd0c28 100644 --- a/var/linuxes/linux-next/sound/aoa/core/gpio-pmf.c +++ b/var/julia/linuxcopy/sound/aoa/core/gpio-pmf.c @@ -182,6 +182,10 @@ static int pmf_set_notify(struct gpio_runtime *rt, if (!old && notify) { irq_client = kzalloc(sizeof(struct pmf_irq_client), GFP_KERNEL);
if (!irq_client) {err = -ENOMEM;goto out_unlock;}