On Fri, Sep 21, 2012 at 04:16:26PM +0300, Peter Ujfalusi wrote:
On 09/21/2012 02:13 PM, Mark Brown wrote:
On Fri, Sep 21, 2012 at 10:54:26AM +0300, Peter Ujfalusi wrote:
pinctrl framework now becoming widely available for SoCs to configure pin multiplexing. Instead of adding the same code to all dai drivers the core can take care of this transparently. Do not make too much noise if pinctrl is not provided via DT for the dai but just use dev_info().
Please fix your word wrapping, I've mentioned this to you before...
I'll reformat it. BTW: The text is edited so it fits in the 'Commit Message' part of git gui.
The line length is perfectly fine, it's the fact that you appear to start each sentence on a new line so we end up with line lengths alternating between normal and extremely short within paragraphs - just look at the above. It's doing absolutely nothing for legibility and it's a constant thing.
It also seems bad that we're ignoring errors, does the pinctl API not stub itself out well enough.
pinctrl_get_select() returns with a pointer to struct pinctrl. If the platform does not have CONFIG_PINCTRL enabled it will return with NULL. If no pinctrl has been specified for the device it will return with error (-ENODEV). Neither of these cases should be considered as error. We do print out with dev_info() to notify the developer, but having pinctrl mux should not be mandatory.
So then why is pinctrl returning errors in the first place if the sensible thing to do is just ignore them?