On Tue, 2019-11-12 at 19:02 +0000, Colin King wrote:
From: Colin Ian King colin.king@canonical.com
There is a block that is indented too deeply, remove the extraneous tabs.
[]
diff --git a/sound/soc/codecs/tas2770.c b/sound/soc/codecs/tas2770.c
[]
@@ -761,12 +761,12 @@ static int tas2770_i2c_probe(struct i2c_client *client, tas2770->reset_gpio = devm_gpiod_get_optional(tas2770->dev, "reset-gpio", GPIOD_OUT_HIGH);
if (IS_ERR(tas2770->reset_gpio)) {if (PTR_ERR(tas2770->reset_gpio) == -EPROBE_DEFER) {tas2770->reset_gpio = NULL;return -EPROBE_DEFER;}
- if (IS_ERR(tas2770->reset_gpio)) {
if (PTR_ERR(tas2770->reset_gpio) == -EPROBE_DEFER) {tas2770->reset_gpio = NULL;return -EPROBE_DEFER;- }
This could remove the IS_ERR and and also remove another indentation level
if (PTR_ERR(tas2770->reset_gpio) == -EPROBE_DEFER) { tas2770->reset_gpio = NULL; return -EPROBE_DEFER; }
or if _really_ desired, (but it seems not really necessary) but this form is used in a few other sound drivers:
if (IS_ERR(tas2770->reset_gpio) && PTR_ERR(tas2770->reset_gpio) == -EPROBE_DEFER) { tas2770->reset_gpio = NULL; return -EPROBE_DEFER; }