On Mon, Feb 17, 2020 at 2:42 PM Samuel Holland samuel@sholland.org wrote:
The digital codec in the A64 is largely compatible with the one in the A33, with two changes:
- It is missing some muxing options for AIF1/2/3 (not currently supported by the driver)
Is this at the pinctrl level or mixer level? If it's at the pinctrl level then it's out of the scope of this driver/binding. It could very well have those signals, just that they aren't routed outside the SoC.
ChenYu
- It does not have the LRCK inversion issue that A33 has
To fix the Left/Right channel inversion on the A64 caused by the A33 LRCK fix, we need to introduce a new compatible for the codec in the A64.
Cc: stable@kernel.org Fixes: ec4a95409d5c ("arm64: dts: allwinner: a64: add nodes necessary for analog sound support") Signed-off-by: Samuel Holland samuel@sholland.org
.../devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml index 55d28268d2f4..7c66409f13ea 100644 --- a/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml +++ b/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml @@ -15,7 +15,9 @@ properties: const: 0
compatible:
- const: allwinner,sun8i-a33-codec
enum:
- allwinner,sun8i-a33-codec
- allwinner,sun50i-a64-codec
reg: maxItems: 1
-- 2.24.1