At Tue, 18 Feb 2014 11:04:19 -0700, Stephen Warren wrote:
On 02/15/2014 02:22 AM, Takashi Iwai wrote:
At Sat, 15 Feb 2014 10:17:33 +0100, Takashi Iwai wrote:
The default parent device can be obtained directly via card object, so we don't need to rely on pci->dev.parent. Since there is no access to pci_dev, we can reduce the inclusion of linux/pci.h, too.
Signed-off-by: Takashi Iwai tiwai@suse.de
I forgot the cover page: these tree patches are trivial cleanups of hda-codec drivers (not the controller) to work without PCI device assignment. The idea was triggered by Dylan's question.
The series seems fine to me, so briefly, Reviewed-by: Stephen Warren swarren@nvidia.com
Thanks. Any chance to work on / submit other changes for Tegra HD-audio support?
As already mentioned, I think a cleaner way would be to write hda_platform.c instead of hacking hda_intel.c with ifdefs. Some code in hda_intel.c (e.g. bus ops and PCM callbacks) can be moved out, either as a new helper module or just merging into snd-hda-codec helper module, so that they can be used by both hda_intel.c and hda_platform.c.
Ideally, we may rename hda_intel.c with hda_pci.c, but I'm afraid this would bring too many regressions for module options.
Takashi