Re: [PATCH 04/12] dt-bindings: pinctrl: Add Cirrus Logic CS48L31/32/33

On 09/11/2022 17:53, Richard Fitzgerald wrote:

Codecs in this family have multiple digital I/O functions for audio, DSP subsystem, GPIO and various special functions. All muxable pins are selectable as either a GPIO or one of the available alternate functions.

Signed-off-by: Richard Fitzgerald rf@opensource.cirrus.com

.../bindings/pinctrl/cirrus,cs48l32.yaml | 98 +++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/cirrus,cs48l32.yaml

diff --git a/Documentation/devicetree/bindings/pinctrl/cirrus,cs48l32.yaml b/Documentation/devicetree/bindings/pinctrl/cirrus,cs48l32.yaml new file mode 100644 index 000000000000..b24fbae6a8f8 --- /dev/null +++ b/Documentation/devicetree/bindings/pinctrl/cirrus,cs48l32.yaml @@ -0,0 +1,98 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pinctrl/cirrus,cs48l32.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Cirrus Logic CS48L32 audio codec pinctrl driver

Drop driver. s/pinctrl/Pin Controller/

+maintainers:

• • patches@opensource.cirrus.com

+description: | +The Cirrus Logic CS48L32 codec has a number of GPIO functions for +interfacing to external hardware. Certain groups of GPIO pins also +have an alternate function.

+The properties for this driver exist within the parent MFD driver node.

Drop driver... so probably entire sentence.

+See the core bindings for the parent MFD driver for an example:

Drop driver. Describe hardware instead.

• Documentation/devicetree/bindings/mfd/cirrus,cs48l32.yaml

+And the generic pinctrl bindings:

• Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt

Drop entire sentence.

+properties:

Your schema does not match on its own. Where is the compatible? This is not how schemas for devices (also MFD) is done.

• pin-settings:
• description:

•  One subnode is required to contain the default settings. It
  

•  contains an arbitrary number of configuration subnodes, one for
  

•  each group or pin configuration you want to apply as a default.
  

• type: object
• patternProperties:

•  '-pins$':
  

•    type: object
  

•    allOf:
  

•      - $ref: "pincfg-node.yaml#"
  

•      - $ref: "pinmux-node.yaml#"
  

Drop quotes.

Except this, test your patches before sending.

Best regards, Krzysztof