On Tue, May 05, 2015 at 11:21:04AM +0100, Qais Yousef wrote:
This series converts the build system to use autotools and splits the files into lib and utils.
Also patch 5 fixes error handling code.
I can't test Android builds but both cross and native compiling worked for me.
I left AUTHORS, ChangeLog and NEWS files empty. I used the license header to fill COPYING.
Okay I have filled the first two and nothing in NEWS :)
Applied this with below changes
This was autgenerated...
----><8---------------- commit 8d68c1aa7b99beb7774eb7a05349d3b00a635d1b Author: Vinod Koul vinod.koul@intel.com Date: Fri May 8 15:48:06 2015 +0530
autotool: update the INSTALL file
toolchains are updating the INSTALL file so take the updated changes
Signed-off-by: Vinod Koul vinod.koul@intel.com
diff --git a/INSTALL b/INSTALL index 7d1c323beae7..2099840756e6 100644 --- a/INSTALL +++ b/INSTALL @@ -1,8 +1,8 @@ Installation Instructions *************************
-Copyright (C) 1994, 1995, 1996, 1999, 2000, 2001, 2002, 2004, 2005, -2006, 2007, 2008, 2009 Free Software Foundation, Inc. +Copyright (C) 1994-1996, 1999-2002, 2004-2013 Free Software Foundation, +Inc.
Copying and distribution of this file, with or without modification, are permitted in any medium without royalty provided the copyright @@ -12,8 +12,8 @@ without warranty of any kind. Basic Installation ==================
- Briefly, the shell commands `./configure; make; make install' should -configure, build, and install this package. The following + Briefly, the shell command `./configure && make && make install' +should configure, build, and install this package. The following more-detailed instructions are generic; see the `README' file for instructions specific to this package. Some packages provide this `INSTALL' file but do not implement all of the features documented @@ -226,6 +226,11 @@ order to use an ANSI C compiler:
and if that doesn't work, install pre-built binaries of GCC for HP-UX.
+ HP-UX `make' updates targets which have the same time stamps as +their prerequisites, which makes it generally unusable when shipped +generated files such as `configure' are involved. Use GNU `make' +instead. + On OSF/1 a.k.a. Tru64, some versions of the default C compiler cannot parse its `<wchar.h>' header file. The option `-nodtk' can be used as a workaround. If GNU CC is not installed, it is therefore recommended @@ -304,9 +309,10 @@ causes the specified `gcc' to be used as the C compiler (unless it is overridden in the site shell script).
Unfortunately, this technique does not work for `CONFIG_SHELL' due to -an Autoconf bug. Until the bug is fixed you can use this workaround: +an Autoconf limitation. Until the limitation is lifted, you can use +this workaround:
- CONFIG_SHELL=/bin/bash /bin/bash ./configure CONFIG_SHELL=/bin/bash + CONFIG_SHELL=/bin/bash ./configure CONFIG_SHELL=/bin/bash
`configure' Invocation ====================== @@ -362,4 +368,3 @@ operates.
`configure' also accepts some other, not widely useful, options. Run `configure --help' for more details.
--
Populated Changelog with:
--><8-------------- [vkoul@vkoul-udesk7 tinycompress (master)]$ git show HEAD~2 commit 4bc24fc5635f934584f59fc6f0fb12653a034ce9 Author: Vinod Koul vinod.koul@intel.com Date: Fri May 8 15:49:05 2015 +0530
Changelog: update to git log
we dont use changelog file as git is a very good log of what we are changing, so point to git log
Signed-off-by: Vinod Koul vinod.koul@intel.com
diff --git a/ChangeLog b/ChangeLog index e69de29bb2d1..b00336cac756 100644 --- a/ChangeLog +++ b/ChangeLog @@ -0,0 +1,3 @@ +For changelog please see the git log of the project + +$ git log
--
Populated author info
----><8------------
commit 4d89264422ce8f06c4b8c5e9e96719743911c65e Author: Vinod Koul vinod.koul@intel.com Date: Fri May 8 15:53:06 2015 +0530
Authors: add information about how to find authors
Signed-off-by: Vinod Koul vinod.koul@intel.com
diff --git a/AUTHORS b/AUTHORS index e69de29bb2d1..e57a20bea0e1 100644 --- a/AUTHORS +++ b/AUTHORS @@ -0,0 +1,4 @@ +To see author of various changes in this project, please run the below git +command + +$ git log --format='%aN'| sort -u
--
Then saw this warn when compiling so fixed it
-------><8----- commit 50c2b03b3d7be9bdf6f7cfdbf730665e3b596086 Author: Vinod Koul vinod.koul@intel.com Date: Fri May 8 16:00:02 2015 +0530
cplay: check the values of fread
This fixes the following warning: cplay.c: In function ‘play_samples’: cplay.c:219:7: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Wunused-result] fread(&header, sizeof(header), 1, file);
Signed-off-by: Vinod Koul vinod.koul@intel.com
diff --git a/src/utils/cplay.c b/src/utils/cplay.c index c46577a3468a..2d1a1760b3ec 100644 --- a/src/utils/cplay.c +++ b/src/utils/cplay.c @@ -207,6 +207,7 @@ void play_samples(char *name, unsigned int card, unsigned int device, char *buffer; int size, num_read, wrote; unsigned int channels, rate, bits; + size_t read;
if (verbose) printf("%s: entry\n", __func__); @@ -216,7 +217,12 @@ void play_samples(char *name, unsigned int card, unsigned int device, exit(EXIT_FAILURE); }
- fread(&header, sizeof(header), 1, file); + read = fread(&header, sizeof(header), 1, file); + if (read != sizeof(header)) { + fprintf(stderr, "Unable to read header \n"); + fclose(file); + exit(EXIT_FAILURE); + }
if (parse_mp3_header(&header, &channels, &rate, &bits) == -1) { fclose(file);