On Wed, Nov 03, 2010 at 05:30:43, Victor Rodriguez wrote:
+static struct da8xx_ohci_root_hub omapl138_hawk_usb11_pdata = {
.set_power = hawk_usb_set_power,.get_power = hawk_usb_get_power,.get_oci = hawk_usb_get_oci,.ocic_notify = hawk_usb_ocic_notify,/* TPS2087 switch @ 5V */Do we have this part on the hawkboard as well?
Yes the TPS2087 is the USB POWER MANAGER that we have on the board AFAIK this is the same and besides it is working, I have tested by my self by plugging different kind of USB devices, mas storage , Mouses and keyboards.
Just wanted to make sure we are not simply copying comments over from EVM code. If you have verified this, no action required.
Also, you are CCing a whole lot of folks on each patch. Instead, you can automate CCing the relevant folks using --cc-cmd=<command> option of git-send-email
Use --cc-cmd="scripts/get_maintainer.pl --pattern-depth=2 -s" to generate list of relevant CCs.
Example:
scripts/get_maintainer.pl -f arch/arm/mach-davinci/board-omapl138-hawk.c --pattern-depth=2 -s
gives:
Kevin Hilman khilman@deeprootsystems.com Russell King linux@arm.linux.org.uk davinci-linux-open-source@linux.davincidsp.com linux-arm-kernel@lists.infradead.org
Recently Kevin requested all patches to CC Linux ARM Kernel mailing list so this should be OK.
scripts/get_maintainer.pl -f sound/soc/davinci/davinci-evm.c --pattern-depth=2 -s
gives:
Liam Girdwood lrg@slimlogic.co.uk Mark Brown broonie@opensource.wolfsonmicro.com alsa-devel@alsa-project.org
This is as per what Liam and Mark have been asking for.
Also, use --dry-run with git-send-email before sending actual emails to make sure the To and CC lists look good.
Ok I have done this
git send-email --dry-run --from "vm.rod25@gmail.com" --to "vm.rod25@gmail.com" --cc-cmd =scripts/get_maintainer.pl patches/sendedv6/*
You should just try:
git send-email --dry-run --from="vm.rod25@gmail.com" --to=davinci-linux-open-source@linux.davincidsp.com --cc-cmd="scripts/get_maintainer.pl --pattern-depth=2 -s"
I just have one question on the --to i think I should put the davinci mailing list as minimum right ? because the cover letter just will be send to me
Yes. --to= should be davinci-linux-open-source@linux.davincidsp.com. You should automatically be CCed by git-send-email because of your sign-offs. If needed you can add an explicit --cc="vm.rod25@gmail.com"
Thanks, Sekhar