Re: [alsa-devel] [PATCH 1/3] ASoC: davinci-mcasp: Handle return value of devm_kasprintf

 Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

On 2017-09-20 13:06, Arvind Yadav wrote:

devm_kasprintf() can fail here and we must check its return value.

Acked-by: Peter Ujfalusi peter.ujfalusi@ti.com

Signed-off-by: Arvind Yadav arvind.yadav.cs@gmail.com

sound/soc/davinci/davinci-mcasp.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)

diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c index f395bbc..d1a4aa2 100644 --- a/sound/soc/davinci/davinci-mcasp.c +++ b/sound/soc/davinci/davinci-mcasp.c @@ -1867,6 +1867,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev) if (irq >= 0) { irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_common", dev_name(&pdev->dev));

• if (!irq_name) {
  

• 	ret = -ENOMEM;
  

• 	goto err;
  

• }
  

  ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, davinci_mcasp_common_irq_handler, IRQF_ONESHOT | IRQF_SHARED,

@@ -1884,6 +1888,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev) if (irq >= 0) { irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_rx", dev_name(&pdev->dev));

• if (!irq_name) {
  

• 	ret = -ENOMEM;
  

• 	goto err;
  

• }
  

  ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, davinci_mcasp_rx_irq_handler, IRQF_ONESHOT, irq_name, mcasp);

@@ -1899,6 +1907,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev) if (irq >= 0) { irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_tx", dev_name(&pdev->dev));

• if (!irq_name) {
  

• 	ret = -ENOMEM;
  

• 	goto err;
  

• }
  

  ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, davinci_mcasp_tx_irq_handler, IRQF_ONESHOT, irq_name, mcasp);

- Péter