Hello.
Понедельник, 6 января 2014, 13:28 UTC от Mark Brown broonie@kernel.org:
On Sun, Jan 05, 2014 at 11:38:35AM +0400, Alexander Shiyan wrote:
This patch adds devicetree support for mc13783-codec. Since we have not compatible string for this codec, just override of_node for allow using phandle of node in the DT.
All DT patches should be sent to the DT maintainers for review.
Documentation/devicetree/bindings/mfd/mc13xxx.txt | 4 +++- drivers/mfd/mc13xxx-core.c | 12 +++++++-----
Since this has MFD updates you also need to send it to the MFD maintainers.
Optional properties:
- fsl,mc13xxx-uses-adc : Indicate the ADC is being used
-- fsl,mc13xxx-uses-codec : Indicate the Audio Codec is being used
This is an incompatible binding change; deprecating is fine but it should still be supported. Is there not a default set of port assignments that can be used?
"fsl,mc13xxx-uses-codec" is not used anywhere and even if it was used, it would not usable, because we can not get to the codec phandle. So I think this change is safe.
- pdev->dev.of_node = of_find_node_by_name(pdev->dev.parent->of_node,
"codec");You shouldn't be messing with the of_node in the struct device, this is managed by the driver model and setting one that wasn't added in sync with everything else can introduce breakage.
Hmm, probably you are right, but I cannot imagine other way to set of_node... Have you other ideas?
- if (priv->adc_ssi_port != MC13783_SSI1_PORT &&
priv->adc_ssi_port != MC13783_SSI2_PORT)return -EINVAL;- if (priv->dac_ssi_port != MC13783_SSI1_PORT &&
priv->dac_ssi_port != MC13783_SSI2_PORT)return -EINVAL;What about DAC or ADC only systems?
In this case we should rewrite this codec driver completely from scratch. ...
Thanks.
---