On Tue, Jul 26, 2011 at 12:18:19PM +0100, Liam Girdwood wrote:
On Mon, 2011-07-25 at 23:22 +0200, Mark Brown wrote:
Yeah, it really should but it's kind of tricky for the reads as we're returning errors in band and we could have 32 bit registers (I'm guessing the platform versions already do) so we lose. :/ Not sure what the best thing to do there is, changing to return the errors out of band for reads is more painful than I care to contemplate.
Oh, I agree it would be painful for a rework here. But why did you suggest this sort of update in a previous patch comment ? (Unless I misunderstood).
Dunno the specific posting but there's two things I can think of:
- This isn't an issue for writes so they can and should pass back error codes, it's only reads that have trouble.
- If I see people converting an error code into -EINVAL or something I tend to complain about that.