On Mon, Sep 26, 2022 at 11:39:50PM +0100, Mark Brown wrote:
On Mon, Sep 26, 2022 at 05:27:41PM -0500, Gustavo A. R. Silva wrote:
On 9/26/22 17:12, Mark Brown wrote:
On Mon, Sep 26, 2022 at 04:40:55PM -0500, Gustavo A. R. Silva wrote:
As documented in submitting-patches.rst please send patches to the maintainers for the code you would like to change. The normal kernel workflow is that people apply patches from their inboxes, if they aren't copied they are likely to not see the patch at all and it is much more difficult to apply patches.
That's exactly what I intended to do:
$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback include/sound/sof/control.h Jaroslav Kysela perex@perex.cz (maintainer:SOUND) Takashi Iwai tiwai@suse.com (maintainer:SOUND) alsa-devel@alsa-project.org (moderated list:SOUND) linux-kernel@vger.kernel.org (open list)
Did you see anything wrong with this or something...?
Yes, you should've also included me and the SOF maintainers. It looks like the MAINTAINERS patterns aren't entirely up to date there unfortunately. Though that said given that you'd picked up on the subject line I'd have expected the signoffs on the commits to also be pointing at the right tree as well.
Subject line heuristics look at X-many commits, but it looks like get_maintainers stops looking at git history by default after 1 year, which seems kind of odd. I had to work at it to get it to emit your name. :)
scripts/get_maintainer.pl --git --git-since=3-years-ago
Seems like it's worth getting the MAINTAINERS regex updated? Is this right?
diff --git a/MAINTAINERS b/MAINTAINERS index a34ec41fbf7a..2560dded0e3e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19261,6 +19261,7 @@ F: Documentation/devicetree/bindings/sound/ F: Documentation/sound/soc/ F: include/dt-bindings/sound/ F: include/sound/soc* +F: include/sound/sof/ F: sound/soc/
SOUND - SOUND OPEN FIRMWARE (SOF) DRIVERS @@ -19275,6 +19276,7 @@ L: sound-open-firmware@alsa-project.org (moderated for non-subscribers) S: Supported W: https://github.com/thesofproject/linux/ F: sound/soc/sof/ +F: include/sound/sof/
SOUNDWIRE SUBSYSTEM M: Vinod Koul vkoul@kernel.org