On Tue, 24 May 2011 06:47:28 +0800 Mark Brown wrote:
On Mon, May 23, 2011 at 01:48:15PM -0700, Randy Dunlap wrote:
On Mon, 23 May 2011 15:45:18 +1000 Stephen Rothwell wrote:
when CONFIG_GPIOLIB is not enabled and CONFIG_GENERIC_GPIO is not enabled:
sound/soc/codecs/ak4641.c:524: error: 'GPIOF_OUT_INIT_LOW' undeclared (first use in this function) sound/soc/codecs/wm8915.c:2857: error: 'GPIOF_OUT_INIT_LOW' undeclared (first use in this function)
What architecture is this on (you should always include information like this anyway so people can try to reproduce what you're seeing)? In any
on x86_64 [adding x86@kernel.org == arch maintainers]
case, please talk to the architecture maintainers about this - it's an issue in the architecture GPIO support (or lack thereof) rather than a driver problem.
except that a driver should not assume that defines like GPIOF_OUT_INIT_LOW are always available.
Also adding Dmitry who submitted the driver - Randy, please try to remember to CC relevant people.
Which driver did Dmitry submit? how would I know that? I don't download every linux-next git tree -- just linux-next tarballs.
ak4641.c says: MODULE_AUTHOR("Harald Welte laforge@gnufiish.org"); [which bounces]
and wm8915.c says: MODULE_AUTHOR("Mark Brown broonie@opensource.wolfsonmicro.com");
--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***