+static unsigned int saif_clkmux;
Can't we just read the register in get_master and spare the static variable?
and is it intended that if you do:
mxs_saif_clkmux_select(1); mxs_saif_clkmux_select(2);
the SAIF_CLKMUX_SEL bitfield ends up being 3?
Yes, it ends up being 3.
Needs to be fixed, of course. The function will need locking then.
extern const struct mxs_saif_data mx28_saif_data[] __initconst; -#define mx28_add_saif(id)
mxs_add_saif(&mx28_saif_data[id])
+#define mx28_add_saif(id, pdata) \
- mxs_add_saif(&mx28_saif_data[id], pdata)
should it be a seperate patch to add pdata for saif devices?
How do you suggest to separate? All changes are mainly to add saif pdata. You mean to move DIGCTL related saif pdata function to another patch?
I think he meant one patch for adding the functions in clock-mx28.c and one patch to use the stuff when adding the pdata. Uwe?
Wolfram