On Thu, Oct 08, 2009 at 03:26:19PM +0200, Mark Brown wrote:
On Thu, Oct 08, 2009 at 02:58:55PM +0300, Eduardo Valentin wrote:
+static struct regulator_consumer_supply rx51_vmmc2_supplies[] = {
- REGULATOR_SUPPLY("avdd_dac", "2-0018"), /* tlv320aic3x */
- REGULATOR_SUPPLY("vdd", "2-0060"), /* tpa6130a2*/
};
avdd_dac is the only supply added for the tlv320aic3x but, for example, the tlv320aic34 has something like 8 supplies from a quick scan of the datasheet. It'd be better to set up all of the supplies, even if only with a fixed voltage regulator supplying them, since when regulator support is added to the CODEC driver it should be requesting all the supplies it needs and therefore fail to instatiate if some are missing.
Right. Should we add 4 instances of drvdd and 2 of iovdd? So, naming those would be like:
REGULATOR_SUPPLY("drvdd0", "2-0018"), /* tlv320aic3x */ REGULATOR_SUPPLY("drvdd1", "2-0018"), /* tlv320aic3x */ REGULATOR_SUPPLY("drvdd2", "2-0018"), /* tlv320aic3x */ REGULATOR_SUPPLY("drvdd3", "2-0018"), /* tlv320aic3x */
or even better:
REGULATOR_SUPPLY("drvdd_b4", "2-0018"), /* tlv320aic3x */ REGULATOR_SUPPLY("drvdd_a4", "2-0018"), /* tlv320aic3x */ REGULATOR_SUPPLY("drvdd_b9", "2-0018"), /* tlv320aic3x */ REGULATOR_SUPPLY("drvdd_a9", "2-0018"), /* tlv320aic3x */
what do you think?
BR