On Fri, Aug 21, 2015 at 12:47:37AM -0700, Nicolin Chen wrote:
On Tue, Aug 18, 2015 at 10:01:54AM +0800, Zidan Wang wrote:
After several open/close sai test with ctrl+c, there will be I/O error. The SAI can't work anymore, can't recover. There will be no frame clock. With adding the software reset in trigger stop, the issue can be fixed.
It doesn't look like a decent fix to me. Is it the only fix that IC team suggests? And why put this reset in the trigger function. Your MEGA fast patch has already included a software reset in the PM runtime functions. When dealing with CTRL+C test cases, that software reset should have worked as well.
The MEGA fast patch add the suspend/resume function, but CTRL+C will not trigger suspend/resume function. When CTRL+C, it will trigger stop and software reset SAI. IC team suggest us to rest it, but I don't know if it's the only fix.
You can try to add SET_RUNTIME_PM_OPS() and to see if the suspend function is called right after pressing ctrl+c.
The runtime suspend function will be call after the power down time. So if i playback again before the power down time, runtime suspend will not be called.
I see.. Can you provide me a test case to reproduce this issue?
1. aplay -Dhw:0 /unit_tests/audio8k16S.wav 2. ctrl+c
Set SAI to master mode, then try it several times.
Best Regards, Zidan Wang