Re: [alsa-devel] duplicated test in sound/soc/codecs/sgtl5000.c

On Thu, Jan 12, 2012 at 10:13:24PM +0100, Julia Lawall wrote:

There is a duplicated test in the function sgtl5000_restore_regs in the file sound/soc/codecs/sgtl5000.c:

           /* this regs depends on the others */
            if (reg == SGTL5000_CHIP_ANA_POWER ||
                    reg == SGTL5000_CHIP_CLK_CTRL ||
                    reg == SGTL5000_CHIP_LINREG_CTRL ||
                    reg == SGTL5000_CHIP_LINE_OUT_CTRL ||
                    reg == SGTL5000_CHIP_CLK_CTRL)
                    continue;

I don't know if some constant other than SGTL5000_CHIP_CLK_CTRL should be tested, or if the second test should just be deleted.

Adding the people who've been working on the driver. Generally this is a good idea when reporting issues like this.