Hi Doug:
在 12/03/2014 01:54 AM, Doug Anderson 写道:
Jianqun,
This ought to be a "v3" patch and ideally ought to describe differences from v2 (after the cut). Please have Kever or Chris review your next patch before sending it out since I think they are familiar with the process.
On Tue, Dec 2, 2014 at 6:52 AM, Jianqun Xu jay.xu@rock-chips.com wrote:
From: Sonny Rao sonnyrao@chromium.org
We need to claim the clock which is driving the codec so that when we enable clock gating, we continue to clock the codec when needed. I make this an optional clock since there might be some applications where we don't need it but can still use the I2S block.
Signed-off-by: Sonny Rao sonnyrao@chromium.org
You still forgot your own signed-off-by. Please try again. See https://patchwork.kernel.org/patch/5334991/
ok, I will add my signed-off-by
i2s->oclk = devm_clk_get(&pdev->dev, "i2s_clk_out");if (IS_ERR(i2s->oclk)) {dev_dbg(&pdev->dev, "Didn't find output clock\n");i2s->oclk = NULL;}You still forgot the blank line here requested by Heiko. Please try again. See https://patchwork.kernel.org/patch/5334991/
Although I thought there needn't a blank ~, I wll add it next patch
if (i2s->oclk)ret = clk_prepare_enable(i2s->oclk);