Re: [PATCH] ASoC: fsl_asrc: Add initialization finishing check in runtime resume

6 Sep 2022


      On Mon, Sep 5, 2022 at 9:15 PM Nicolin Chen nicoleotsuka@gmail.com wrote:
...
On Mon, Sep 5, 2022 at 3:47 AM Shengjiu Wang shengjiu.wang@nxp.com
wrote:
...
@@ -1295,6 +1301,17 @@ static int fsl_asrc_runtime_resume(struct device
*dev)
...
    regmap_update_bits(asrc->regmap, REG_ASRCTR,
                       ASRCTR_ASRCEi_ALL_MASK, asrctr);



  /* Wait for status of initialization for every enabled pairs */


  do {


          udelay(5);


          regmap_read(asrc->regmap, REG_ASRCFG, &reg);


          reg = (reg >> ASRCFG_INIRQi_SHIFT(0)) & 0x7;


  } while ((reg != ((asrctr >> ASRCTR_ASRCEi_SHIFT(0)) & 0x7)) &&



--retry);
...


  /* FIXME: Doesn't treat initialization timeout as error */


  if (!retry)


          dev_warn(dev, "initialization isn't finished\n");



Any reason why not just dev_err?
Just hesitate to use dev_err. if use dev_err, then should return an error.
May one of the pairs is finished, it still can continue.
Best regards
Wang Shengjiu

    