Hi Rob,
On 14/02/24 7:28 pm, Rob Herring wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
On Wed, Feb 14, 2024 at 12:10:06PM +0530, Balakrishnan Sambath wrote:
Convert atmel-at91sam9g20ek-wm8731-audio DT binding to yaml based json-schema.Change file name to match json-scheme naming.
Signed-off-by: Balakrishnan Sambath balakrishnan.s@microchip.com
.../bindings/sound/atmel,at91sam9g20ek-wm8731.yaml | 60 ++++++++++++++++++++++ .../sound/atmel-at91sam9g20ek-wm8731-audio.txt | 26 ---------- 2 files changed, 60 insertions(+), 26 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/atmel,at91sam9g20ek-wm8731.yaml b/Documentation/devicetree/bindings/sound/atmel,at91sam9g20ek-wm8731.yaml new file mode 100644 index 000000000000..f6330707fe1b --- /dev/null +++ b/Documentation/devicetree/bindings/sound/atmel,at91sam9g20ek-wm8731.yaml @@ -0,0 +1,60 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/atmel,at91sam9g20ek-wm8731.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Atmel at91sam9g20ek wm8731 audio complex
+maintainers:
- Balakrishnan Sambath balakrishnan.s@microchip.com
+properties:
- compatible:
- const: atmel,at91sam9g20ek-wm8731-audio
- atmel,model:
- $ref: /schemas/types.yaml#/definitions/string
- description: The user-visible name of this sound complex.
blank line between DT properties
sure, thanks for pointing it out. I'll fix this in v2
- atmel,audio-routing:
- $ref: /schemas/types.yaml#/definitions/non-unique-string-array
- description: A list of the connections between audio components.
- minItems: 2
No max?
Here, there's no explicit constraint on the maximum number of items, so I only enforced minItems. Please let me know if I'm doing something wrong.
- items:
enum:# Board Connectors- "Ext Spk"- "Int MIC"# CODEC Pins- LHPOUT- MICIN- atmel,ssc-controller:
- $ref: /schemas/types.yaml#/definitions/phandle
- description: The phandle of the SSC controller
- atmel,audio-codec:
- $ref: /schemas/types.yaml#/definitions/phandle
- description: The phandle of WM8731 audio codec
+required:
- compatible
- atmel,model
- atmel,audio-routing
- atmel,ssc-controller
- atmel,audio-codec
+additionalProperties: false
+examples:
- |
- sound {
compatible = "atmel,at91sam9g20ek-wm8731-audio";pinctrl-names = "default";pinctrl-0 = <&pinctrl_pck0_as_mck>;atmel,model = "wm8731 @ AT91SAMG20EK";atmel,audio-routing ="Ext Spk", "LHPOUT","Int MIC", "MICIN";atmel,ssc-controller = <&ssc0>;atmel,audio-codec = <&wm8731>;- };