7 Jul
2021
7 Jul
'21
6:17 p.m.
On Wed, Jul 07, 2021 at 11:26:13AM +0530, Vijendar Mukunda wrote:
+static inline u32 acp_readl(void __iomem *base_addr) +{
- return readl(base_addr - ACP5x_PHY_BASE_ADDRESS);
+}
I see this was the same for Renoir but it's weird that the read and write functions are substracting rather than adding the base address here. A comment might be good.