Re: [alsa-devel] [PATCH 2/2] ALSA: ASoC: add WM8782 ADC Codec Driver

On Tue, Jun 14, 2011 at 09:27:06PM +0200, Daniel Mack wrote:

• .rates = SNDRV_PCM_RATE_48000,
  

Datasheet says 8kHz to 192kHz are supported, there's a pin strap to select 96kHz and 192kHz rates so those could be omitted with a comment at a first pass.

•           .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE,
  

20 bit is also supported.

• .driver = {

• .name = "wm8782-codec",
  

Drop the -codec - not only is it redundant but the device is an ADC only.

• .owner = THIS_MODULE,
  

• },
• .probe = wm8782_probe,
• .remove = wm8782_remove,

+};

+static int __init wm8782_init(void) +{

• return platform_driver_register(&wm8782_codec_driver);

+} +module_init(wm8782_init);

+static void __exit wm8782_exit(void) +{

• platform_driver_unregister(&wm8782_codec_driver);

+} +module_exit(wm8782_exit);

+MODULE_DESCRIPTION("ASoC WM8782 driver"); +MODULE_AUTHOR("Johannes Stezenbach js@sig21.net");

+MODULE_LICENSE("GPL");

1.7.5.1