24 Apr
2014
24 Apr
'14
4:05 p.m.
On 04/24/2014 04:03 PM, Mark Brown wrote:
On Thu, Apr 24, 2014 at 03:47:59PM +0300, Jyri Sarha wrote:
On 04/24/2014 02:13 PM, Nicolin Chen wrote:
Please delete unneeded context from your mails...
- if (!strcmp("sound", node->name))
prefix = "simple-audio-card,";
- prefix = "simple-audio-card,";
I think you have missed the point of selecting the prefix based on the node name.
...
Maybe the implementation could have been more explicit, but I think the old behavior is more convenient. If we anyway decide to go with this change then at least the DT binding document should be updated.
Yes, the implementation needs to be *way* more explicit - I'd expect a parameter/variable saying which level we're at depending on where we're at in the parse rather than guessing based on the node name.
Ok, I'll come up with a patch soon.
Best regards, Jyri