29 Aug
2011
29 Aug
'11
4:05 p.m.
Jassi Brar wrote:
On Mon, Aug 29, 2011 at 6:01 PM, Felipe Balbi balbi@ti.com wrote:
100ms might not be enough for slower devices. Increasing timeout to 1000ms doesn't seem like overkill.
Signed-off-by: Felipe Balbi balbi@ti.com
Changes since v1: . Increase all 100ms timeout to 1000ms
sound/usb/mixer.c | 4 ++-- sound/usb/mixer_quirks.c | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-)
The calls in mixer_quirks.c are device-specific and known to work, so none of them actually require a longer timeout. However, increasing their timeout doesn't hurt either, and ...
buf, val_len, 1000) >= val_len) {buf, val_len, 1000) >= 0) {!value, 0, NULL, 0, 1000);!value, 0, NULL, 0, 1000);value, index + 2, NULL, 0, 1000);jacks[i].unitid << 8, buf, 3, 1000);50, 0, &new_status, 1, 1000);How about also converting to use a local define for timeout value ?
... now that _all_ calls to snd_usb_ctl_msg use the same timeout value, we could just as well drop this parameter.
Regards, Clemens