-----Original Message----- From: Mark Brown [mailto:broonie@kernel.org] Sent: Wednesday, January 28, 2015 7:36 PM To: Bard Liao Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; Flove; Oder Chiou; yang.jie@intel.com Subject: Re: [PATCH] ASoC: rt286: set idle_bias_off to false
On Wed, Jan 28, 2015 at 04:59:57PM +0800, Bard Liao wrote:
We do the power down process at bias level STANDBY. And do nothing at bias level OFF. As a result, the register setting is the same between bias level STANDBY and OFF. So we don't need to set idle_bias_off true.
- .idle_bias_off = true,
- .idle_bias_off = false,
There is no need to set false explicitly, it's the default. It also seems better to keep the flag if it's true, even if we don't actively do anything at the minute we may in future (either in the framework or in the driver) so the information seems useful.
Actually, we meet an issue. We use force enable in rt286_jack_detect. If a headset is inserted, the bias_level will not be OFF due to some widgets are ON. If idle_bias_off is true, rt286_suspend will not be invoked in suspend. And I "guess" rt286's power will be cut off in suspend. That's what we handle in rt286_suspend/resume functions. If rt286 's power is cut off and don't re-sync the cache, it will cause some unexpected issues.
Is there any good way to fix such issues?
Thanks.
------Please consider the environment before printing this e-mail.