On 10/05/2023 09:42, AS50 CTLin0 wrote:
On 5/10/2023 3:19 PM, Krzysztof Kozlowski wrote:
On 10/05/2023 05:44, David Lin wrote:
Convert the NAU8825 audio CODEC bindings to DT schema.
Signed-off-by: David Lin CTLIN0@nuvoton.com
Version your patches and provide changelog after ---.
If you just send the same with the same mistakes, that's a NAK.
I know your meanings is to show change log from v1 to v2, but I see previous patch have other missing items.
I don't understand it. It does not matter what else is missing in previous patch. You always must version them and always provide changelog.
Therefore, I revise it and included your comments. Anyway, I can back to previous patch and re-send v2 patch with changelog.
Paste it here (and in v3 of course).
.../devicetree/bindings/sound/nau8825.txt | 111 -------- .../bindings/sound/nuvoton,nau8825.yaml | 242 ++++++++++++++++++ 2 files changed, 242 insertions(+), 111 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/nau8825.txt create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8825.yaml
+required:
- compatible
- reg
+unevaluatedProperties: false
+examples:
- |
- #include <dt-bindings/gpio/gpio.h>
- #include <dt-bindings/interrupt-controller/irq.h>
- i2c {
#address-cells = <1>;#size-cells = <0>;nau8825@1a {This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them.
Thank you.
Best regards, Krzysztof
About node item, maybe I misunderstand your meanings.
When I change from headset: nau8825@1a to audio-codec: nau8825@1a, it will have compiler error.
That's label, not nodename. Why would even this create a compile error?
So I use nau8825@1a to submit.However, when I see your latest comment, I seems to understand your point for node name.
The final result will be codec@1a or audio-codec@1a, right?
Yes.
Best regards, Krzysztof