30 Jan
2019
30 Jan
'19
5:12 p.m.
On 1/29/19 10:49 AM, Daniel Baluta wrote:
<snip>
diff --git a/sound/soc/sof/core.c b/sound/soc/sof/core.c
<snip>
+/* SOF defaults if not provided by the platform in ms */
/* firmware loader */
int cl_bar;
This cl_bar variable seems to be only assigned to but never used.
I propose to remove it if there is no much trouble.
Indeed, not sure what it's supposed to be used for, it was part of the initial commit for all the files below and never used. If it's not been used in a year it's probably useless, I'll remove it.
git grep cl_bar
intel/bdw.c: sdev->cl_bar = BDW_DSP_BAR; intel/byt.c: sdev->cl_bar = BYT_DSP_BAR; intel/byt.c: sdev->cl_bar = BYT_DSP_BAR; intel/hsw.c: sdev->cl_bar = HSW_DSP_BAR; sof-priv.h: int cl_bar;