The mpc5200_dma overwrites the private_data field of the CODEC's AC'97 device with the DMA drivers private data, but never actually reads it again. Given that the private_data field is supposed to be owned by the AC'97 driver, overwriting it may cause undefined behavior. This patch removes the code that overwrites the field from the driver.
Signed-off-by: Lars-Peter Clausen lars@metafoo.de --- sound/soc/fsl/mpc5200_dma.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/sound/soc/fsl/mpc5200_dma.c b/sound/soc/fsl/mpc5200_dma.c index f2b5d75..0b82e20 100644 --- a/sound/soc/fsl/mpc5200_dma.c +++ b/sound/soc/fsl/mpc5200_dma.c @@ -327,9 +327,6 @@ static int psc_dma_new(struct snd_soc_pcm_runtime *rtd) goto capture_alloc_err; }
- if (rtd->codec->ac97) - rtd->codec->ac97->private_data = psc_dma; - return 0;
capture_alloc_err: