Re: [alsa-devel] [PATCH 3/4] ASoC: ts3a227e: add platform data for ts3a227e driver

30 Apr 2015


      On Wed, Apr 29, 2015 at 06:43:57PM -0700, yang.a.fang@intel.com wrote:
...
@@ -296,7 +303,7 @@ static int ts3a227e_i2c_probe(struct i2c_client *i2c,
   }
ret = devm_request_threaded_irq(dev, i2c->irq, NULL, ts3a227e_interrupt,

			IRQF_TRIGGER_LOW | IRQF_ONESHOT,




			ts3a227e->pdata.irqflag,
		"TS3A227E", ts3a227e);

if (ret) {
dev_err(dev, "Cannot request irq %d (%d)\n", i2c->irq, ret);

This doesn't make much sense to me - no change is made to the
configuration of the device, the driver just passes the flag through to
the interrupt controller code.  I can't see how that's going to work
well, somewhere along the line something must be misconfigured.

    

Mark Brown