On Tue, 17 Sep 2019 at 14:06, Maciej Falkowski m.falkowski@samsung.com wrote:
Convert Samsung SMDK audio complex to newer dt-schema format.
Signed-off-by: Maciej Falkowski m.falkowski@samsung.com Signed-off-by: Marek Szyprowski m.szyprowski@samsung.com
v2:
- Added missing Signed-off-by certificate
I understood you cannot certify that you have the rights to send the patch. Adding someone's else Signed-off-by does not solve the problem of lack of such permission. Marek could certify that but you cannot certify for him. Otherwise it really makes the process bogus - anyone can add Linus' SoB and say that Linus certified the rights to include this contribution.
In my understanding of Developer's Certificate of Origin 1.1, these patches do not meet the criteria and therefore should not be included from that point of view.
One minor comment further.
.../bindings/sound/samsung,smdk-wm8994.txt | 14 ------- .../bindings/sound/samsung,smdk-wm8994.yaml | 38 +++++++++++++++++++ 2 files changed, 38 insertions(+), 14 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/samsung,smdk-wm8994.txt create mode 100644 Documentation/devicetree/bindings/sound/samsung,smdk-wm8994.yaml
diff --git a/Documentation/devicetree/bindings/sound/samsung,smdk-wm8994.txt b/Documentation/devicetree/bindings/sound/samsung,smdk-wm8994.txt deleted file mode 100644 index 4686646fb122..000000000000 --- a/Documentation/devicetree/bindings/sound/samsung,smdk-wm8994.txt +++ /dev/null @@ -1,14 +0,0 @@ -Samsung SMDK audio complex
-Required properties: -- compatible : "samsung,smdk-wm8994" -- samsung,i2s-controller: The phandle of the Samsung I2S0 controller -- samsung,audio-codec: The phandle of the WM8994 audio codec -Example:
-sound {
compatible = "samsung,smdk-wm8994";samsung,i2s-controller = <&i2s0>;samsung,audio-codec = <&wm8994>;-}; diff --git a/Documentation/devicetree/bindings/sound/samsung,smdk-wm8994.yaml b/Documentation/devicetree/bindings/sound/samsung,smdk-wm8994.yaml new file mode 100644 index 000000000000..a66c0dfdeb57 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/samsung,smdk-wm8994.yaml @@ -0,0 +1,38 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/samsung,smdk-wm8994.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Samsung SoC SMDK audio complex
+maintainers:
- Krzysztof Kozlowski krzk@kernel.org
- Sangbeom Kim sbkim73@samsung.com
Unfortunately there was no mails coming from Sangbeom Kim so I think he is not active in maintaining these pieces. Let's skip this entry.
Best regards, Krzysztof
- Sylwester Nawrocki s.nawrocki@samsung.com
+properties:
- compatible:
- const: "samsung,smdk-wm8994"
- samsung,i2s-controller:
- $ref: /schemas/types.yaml#/definitions/phandle
- description: The phandle of the Samsung I2S0 controller
- samsung,audio-codec:
- $ref: /schemas/types.yaml#/definitions/phandle
- description: The phandle of the WM8994 audio codec
+required:
- compatible
- samsung,i2s-controller
- samsung,audio-codec
+examples:
- |
- sound {
compatible = "samsung,smdk-wm8994";samsung,i2s-controller = <&i2s0>;samsung,audio-codec = <&wm8994>;- };
-- 2.17.1