19 Feb
2020
19 Feb
'20
4:55 p.m.
On Wed, Feb 19, 2020 at 02:36:46PM +0100, Jerome Brunet wrote:
Looks good, couple of small things below:
+static const struct snd_kcontrol_new t9015_snd_controls[] = {
- /* Volume Controls */
- SOC_SINGLE("Playback Mute", VOL_CTRL1, DAC_SOFT_MUTE, 1, 0),
This should be Switch (see control-names.rst).
- SOC_SINGLE("Volume Ramp Enable", VOL_CTRL1, VC_RAMP_MODE, 1, 0),
- SOC_SINGLE("Mute Ramp Enable", VOL_CTRL1, MUTE_MODE, 1, 0),
- SOC_SINGLE("Unmute Ramp Enable", VOL_CTRL1, UNMUTE_MODE, 1, 0),
These too.
- /* Channel Src */
- SOC_ENUM("Right DAC Source", dacr_in_enum),
- SOC_ENUM("Left DAC Source", dacl_in_enum),
Ideally these would be moved into DAPM (using an AIF_IN widget for the DAI).