On Thu, May 28, 2009 at 10:00 AM, Peter Korsgaard jacmet@sunsite.dk wrote:
"Jon" == Jon Smirl jonsmirl@gmail.com writes:
Hi,
Jon> Fabric bindings for STAC9766 AC97 codec on the Efika. Jon> Signed-off-by: Jon Smirl jonsmirl@gmail.com Jon> --- Jon> sound/soc/fsl/Kconfig | 8 +++ Jon> sound/soc/fsl/Makefile | 1 Jon> sound/soc/fsl/efika-audio-fabric.c | 95 ++++++++++++++++++++++++++++++++++++ Jon> 3 files changed, 104 insertions(+), 0 deletions(-) Jon> create mode 100644 sound/soc/fsl/efika-audio-fabric.c
Jon> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig Jon> index 79579ae..f571c6e 100644 Jon> --- a/sound/soc/fsl/Kconfig Jon> +++ b/sound/soc/fsl/Kconfig Jon> @@ -47,3 +47,11 @@ config SND_MPC52xx_SOC_PCM030 Jon> help Jon> Say Y if you want to add support for sound on the Phytec pcm030 baseboard.
Jon> +config SND_MPC52xx_SOC_EFIKA Jon> + tristate "SoC AC97 Audio support for bbplan Efika and STAC9766" Jon> + depends on PPC_EFIKA Jon> + select SND_SOC_MPC5200_AC97 Jon> + select SND_SOC_STAC9766 Jon> + help Jon> + Say Y if you want to add support for sound on the Efika. Jon> +
Wouldn't it make more sense to make this default y when it has such specific dependencies and is so deep down in the tree - Most efika users probably want to enable this if they have enabled ALSA and SND_SOC?
I can change it in the next round of updates. Right now I'd like to get some people testing it and maybe doing some patches to enhance it.
For example I know he code has a problem where about 5% of the time the codec doesn't reset right on boot. Someone needs to put an oscilloscope on the codec chip and tell me why it is failing.
-- Bye, Peter Korsgaard