On Sun, Apr 07, 2013 at 10:35:02PM +0200, Lars-Peter Clausen wrote:
On 04/07/2013 10:08 PM, Markus Pargmann wrote:
Hi,
On Sun, Apr 07, 2013 at 09:39:31PM +0200, Lars-Peter Clausen wrote:
On 04/07/2013 09:25 PM, Markus Pargmann wrote:
Hi,
This series adds DT support for phycore-ac97 using the fsl-ssi driver. In version 2 I discarded most of the imx-ssi work and integrated the ac97-slave support in fsl-ssi, including support for imx-pcm-fiq as alternative to dma. There are some other changes to get phycore-ac97 working. The first two patches have notes about the detailed changes since version 1. The rest of the patches is new and necessary for the ac97-slave support.
Regards,
Markus
Hi,
The DMA PCM related changes won't apply anymore due to the recent dmaengine PCM cleanups. I've also been working on a more generic dmaengine PCM driver which has DT support and can be used by imx. The work in progress patches can be found here: https://github.com/lclausen-adi/linux-2.6/commits/asoc-dmaengine-cleanups
- Lars
Okay, I will rebase it for v3 onto your committed cleanups and will have a look on your latest patches.
It might be a good idea to rebase it ontop of the generic dmaengine driver patches right away, since it will simplify things quite a bit.
I rebased the series onto your branch now. But there is a small problem with the DMA handling.
Currently you pass the device pointer into snd_dmaengine_pcm_register and use it to request the dma channels. At least for imx-pcm-audio driver, it would be useful to pass a second device just for the dma requests. Otherwise imx-pcm-audio needs devicetree bindings, but I think the dma properties belong to fsl-ssi.
Regards,
Markus
- Lars
Regards,
Markus
Markus Pargmann (11): ASoC: phycore-ac97: Add DT support ASoC: imx-pcm-dma: Add support for DMA init by ASoC: imx-pcm-fiq: Introduce pcm-fiq-params ASoC: fsl-ssi: Add SACNT definitions ASoC: fsl-ssi: Add support for imx-pcm-fiq ASoC: fsl-ssi: Setup generic imx dma params ARM: imx: Export ac97 reset functions ASoC: fsl-ssi: imx ac97 support ASoC: fsl: Kconfig: Use fsl-ssi for phycore-ac97 ASoC: fsl: Move fsl-ssi binding doc to sound/ ASoC: fsl: Update fsl-ssi binding doc
Documentation/devicetree/bindings/powerpc/fsl/ssi.txt | 73 - Documentation/devicetree/bindings/sound/fsl,ssi.txt | 13 b/Documentation/devicetree/bindings/sound/fsl,ssi.txt | 73 + b/Documentation/devicetree/bindings/sound/phytec,phycore-ac97.txt | 12 b/arch/arm/mach-imx/mach-pca100.c | 7 b/arch/arm/mach-imx/mach-pcm043.c | 7 b/sound/soc/fsl/Kconfig | 2 b/sound/soc/fsl/fsl_ssi.c | 70 + b/sound/soc/fsl/fsl_ssi.h | 8 b/sound/soc/fsl/imx-pcm-dma.c | 31 b/sound/soc/fsl/imx-pcm-fiq.c | 14 b/sound/soc/fsl/imx-pcm.h | 6 b/sound/soc/fsl/imx-ssi.c | 7 b/sound/soc/fsl/imx-ssi.h | 1 b/sound/soc/fsl/phycore-ac97.c | 185 ++++ sound/soc/fsl/fsl_ssi.c | 379 +++++++--- sound/soc/fsl/imx-pcm.h | 9 17 files changed, 664 insertions(+), 233 deletions(-)
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel