Re: [alsa-devel] [PATCH] ASoC: tlv320aic31xx: Add HP output driver pop reduction controls

On Thu, Nov 28, 2019 at 12:39:55PM +0300, Nikita Yushchenko wrote:

+static const char * const hp_poweron_time_text[] = {

• "0us", "15.3us", "153us", "1.53ms", "15.3ms", "76.2ms",
• "153ms", "304ms", "610ms", "1.22s", "3.04s", "6.1s" };

+static SOC_ENUM_SINGLE_DECL(hp_poweron_time_enum, AIC31XX_HPPOP, 3,

• hp_poweron_time_text);

+static const char * const hp_rampup_step_text[] = {

• "0ms", "0.98ms", "1.95ms", "3.9ms" };

+static SOC_ENUM_SINGLE_DECL(hp_rampup_step_enum, AIC31XX_HPPOP, 1,

• hp_rampup_step_text);

I'm not seeing any integration with DAPM here, I'd expect to see that so we don't cut off the start of audio especially with the longer times available (which I'm frankly not sure are seriously usable).