On Wed, Jan 21, 2009 at 01:08:37AM +0100, Takashi Iwai wrote:
At Tue, 20 Jan 2009 21:08:22 +0530, Jaswinder Singh Rajput wrote:
usr/include/linux/soundcard.h is giving following warnings for 'make headers_check': usr/include/linux/soundcard.h:1047: extern's make no sense in userspace usr/include/linux/soundcard.h:1048: extern's make no sense in userspace usr/include/linux/soundcard.h:1049: extern's make no sense in userspace usr/include/linux/soundcard.h:1050: extern's make no sense in userspace usr/include/linux/soundcard.h:1051: extern's make no sense in userspace usr/include/linux/soundcard.h:1053: extern's make no sense in userspace usr/include/linux/soundcard.h:1055: extern's make no sense in userspace usr/include/linux/soundcard.h:1056: extern's make no sense in userspace usr/include/linux/soundcard.h:1061: extern's make no sense in userspace usr/include/linux/soundcard.h:1062: extern's make no sense in userspace usr/include/linux/soundcard.h:1078: extern's make no sense in userspace usr/include/linux/soundcard.h:1079: extern's make no sense in userspace
Do we need to fix these warnings.
No, these are declarations for OSS-lib. It doesn't belong to kernel, but it's better to keep it for compatibility in some way.
But not in the kernel for sure. I just checked and for example: OSS_init is not used anywhere in the kernel. The kernel headers are not a "dump all your stuff" ground anymore.
So I encourage you to find a better home for the user space library definitons. We can let the definiton stay for a while - but eventually they have to be dropped from the kernel.
Sam