On Mon, Aug 22, 2011 at 08:20:29PM +0800, Dong Aisheng wrote:
- add different clkmux mode handling for record.
SAIF can use two instances to implement full duplex (playback & recording) and record saif may work on EXTMASTER mode that is using other saif's BITCLK&LRCLK. The clkmux mode is determined by saif's platform data and machine specific clkmux setting is done in pdata->init(). 2. support playback and capture simutaneously however the sample rates can not be different due to hw limitation.
Signed-off-by: Dong Aisheng b29396@freescale.com
First thanks to Aisheng for doing this and the discussions we had so far :) It is what we agreed one, yet there is one detail we had overlooked and we need to sort it out. After that, I think the patch can go in, because it works fine on my side.
/*
- Since SAIF may work on EXTMASTER mode, IOW, it's working BITCLK&LRCLK
- is provided by other SAIF, we provide a interface here to get its master.
- Note that for DIRECT mode, it's master is itself.
- */
+static struct mxs_saif *mxs_saif_get_master(struct mxs_saif * saif) +{
- struct mxs_saif *master_saif;
- /* get master saif according to different clkmux setting */
- switch (saif->clkmux) {
- case MXS_DIGCTL_SAIF_CLKMUX_DIRECT:
master_saif = saif;break;- case MXS_DIGCTL_SAIF_CLKMUX_CROSSINPUT:
master_saif = saif->id ? mxs_saif[1] : mxs_saif[0];break;- case MXS_DIGCTL_SAIF_CLKMUX_EXTMSTR0:
master_saif = mxs_saif[0];break;- case MXS_DIGCTL_SAIF_CLKMUX_EXTMSTR1:
master_saif = mxs_saif[1];break;- default:
return NULL;- }
- return master_saif;
+}
A get_master() function is probably the best we can do; yet we pull in some mach-specific details here, namely the MXS_DIGCTL_SAIF_CLKMUX_* macros. So, either
a) we keep going the way that mach-specific stuff has to live outside the generic driver. Then, we probably need some custom get_master()-callback (like we have an init()-callback already) which basically works like
master_id = pdata->get_saif_master(saif->id);
or b) we accept for now that this driver is heavily mxs specific and keep this code in the driver. Then, we could also get rid of the init()-callback, because it usually only calls mxs_saif_clkmux_select() which could also happen here.
According to Aisheng, saif-devices will not be used in later SoC, but we all probably know that things pop up unexpectedly, right? ;)
Comments,
Wolfram