17 Jul
2015
17 Jul
'15
8:04 p.m.
On Wed, Jul 15, 2015 at 11:15:42AM +0800, Xing Zheng wrote:
This looks pretty good, a couple of minor points below which should be quick to fix.
+static int rk_init(struct snd_soc_pcm_runtime *runtime) +{
- struct snd_soc_card *card = runtime->card;
- card->dapm.idle_bias_off = true;
You shouldn't need to do this? If you do need to do it we should make it possible to do it from the card struct.
- ret = snd_soc_register_card(card);
- if (ret) {
pr_err("snd_soc_register_card failed %d\n", ret);return ret;- }
- ret = snd_soc_of_parse_card_name(card, "rockchip,model");
- if (ret)
return ret;
This should be devm_snd_soc_register_card() and you need to parse the card name before registering it, otherwise the card might instantiate before the name is set.
+static int snd_rk_mc_remove(struct platform_device *pdev) +{
- struct snd_soc_card *soc_card = platform_get_drvdata(pdev);
- snd_soc_card_set_drvdata(soc_card, NULL);
- snd_soc_unregister_card(soc_card);
- platform_set_drvdata(pdev, NULL);
No need for any of the _set_drvdata() calls, the core does them and they shouldn't make any difference anyway.