Re: [alsa-devel] [PATCH 4/5] ASoC: simple-card: Support setting mclk via a fixed factor

On Thu, Apr 17, 2014 at 05:53:13PM +0200, Andrew Lunn wrote:

+- simple-audio-card,mclk-factor : Multiplication factor between stream rate and codec

• 			  mclk.
  

The normal name for this is fs rather than factor.

• if (priv->mclk_factor) {

• mclk = params_rate(params) * priv->mclk_factor;
  

• ret = snd_soc_dai_set_sysclk(codec_dai, 0, mclk,
  

• 			     SND_SOC_CLOCK_IN);
  

• }

We also need to consider what happens in cases where a clock is specified via the clocks property. I would expect this to be used to set the rate for that clock as well.