On Mon, Feb 03, 2020 at 11:01:44PM -0700, Nathan Chancellor wrote:
Clang warns:
../sound/soc/codecs/wcd934x.c:1886:11: warning: address of array 'wcd->rx_chs' will always evaluate to 'true' [-Wpointer-bool-conversion] if (wcd->rx_chs) { ~~ ~~~~~^~~~~~ ../sound/soc/codecs/wcd934x.c:1894:11: warning: address of array 'wcd->tx_chs' will always evaluate to 'true' [-Wpointer-bool-conversion] if (wcd->tx_chs) { ~~ ~~~~~^~~~~~ 2 warnings generated.
Arrays that are in the middle of a struct are never NULL so they don't need a check like this.
I'm not convincd this is a sensible warning, at the use site a pointer to an array in a struct looks identical to an array embedded in the struct so it's not such a bad idea to check and refactoring of the struct could easily introduce problems.