On 12-04-19, 16:21, Takashi Iwai wrote:
On Fri, 12 Apr 2019 16:18:41 +0200, Mark Brown wrote:
On Fri, Apr 12, 2019 at 09:07:41AM -0500, Pierre-Louis Bossart wrote:
config CODEC_XYX_SDW tristate "XYZ SDW Codec" depends on SOUNDWIRE select REGMAP_SOUNDWIRE
That looks good.
config REGMAP_SOUNDWIRE select SOUNDWIRE_BUS
it'd follow the typical pattern seen in sound/soc/codecs/Kconfig:
IIRC the select here won't actually do anything.
I thought it'd do select SOUNDWIRE_BUS. The depends-on here would be ignored instead.
yeah this all is bit complicated and should not be so. As Srini pointed out, we have two symbols, SOUNDWIRE as a menuconfig item which enables the subsystem and then SOUNDWIRE_BUS which compiles in the code.
Unfortunately I dont seem to recall the advantages of this approach so it might be easier to drop SOUNDWIRE_BUS and then let codecs do select REGMAP_SOUNDWIRE and depends on SOUNDWIRE
Thanks